Fix a race in temp file creation. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexand
force-pushed
the
no-race-tempfile
branch
2 times, most recently
from
13f5fc0 to
2c1365a
Compare
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 67.12% 67.14% +0.02%
==========================================
Files 78 78
Lines 14062 14072 +10
==========================================
+ Hits 9439 9449 +10
+ Misses 3790 3788 -2
- Partials 833 835 +2
Continue to review full report at Codecov.
|
nolanmar511
previously approved these changes
Oct 5, 2020
kalyanac
reviewed
Oct 5, 2020
internal/driver/tempfile.go
Outdated
| if !os.IsNotExist(err) { | ||
| return nil, err | ||
| } | ||
| f, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666) |
There was a problem hiding this comment.
I dont think Stat() is needed. Just call OpenFile with os.O_RDWR|os.O_CREATE|os.O_EXCL directly and handle err as needed. If this is racy, checking Stat() prior to OpenFile does not guarantee success in all cases.
There was a problem hiding this comment.
Done. I thought about this and left the os.Stat() call to avoid spurious write accesses - somehow it felt better to only probe with a read rather than with a write. But it shouldn't matter as far as I can think of it, and less code is good.
aalexand
force-pushed
the
no-race-tempfile
branch
from
fd3b664 to
8d5037f
Compare
The added test fails before the fix and passes after. Fixes google#500.
aalexand
force-pushed
the
no-race-tempfile
branch
from
8d5037f to
a13cf9d
Compare
kalyanac
approved these changes
Oct 6, 2020
NHDaly
added a commit
to NHDaly/Yggdrasil
that referenced
this pull request
Nov 13, 2020
Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504
giordano
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Nov 13, 2020
* Update pprof to latest revision Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504 * Update P/pprof/build_tarballs.jl - use a real version number Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Remove now unused `timestamp` * [pprof] Use `GitSource` Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
The added test fails before the fix and passes after. Fixes google#500.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test fails before the fix and passes after.
Fixes #500.